-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to solc 0.4.24 #383
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
7cd1f45
Bump to solc 0.4.24
izqui ba41180
Update to new constructor syntax and fix tests
izqui 04c3dde
Use 'block.timestamp' instead of deprecated 'now'
izqui e22a882
Fix StandardToken tests
izqui 8a3e40b
Fix lint
izqui 7471d08
Fix compiler warnings except for lib contracts
izqui eb0f4ba
Update solc pragma for recently new contracts and mocks
izqui 2993bc9
Use solc abi.encodeWithSelector instead of custom encoding
izqui 2056fe0
Cleanup
izqui 97b835b
Remove unused memcpy from ScriptHelpers
izqui cae3501
Update to solidity-coverage 0.5.7, moves mocks to contract dir
izqui bf647a8
Fix KernelConstants test
izqui 04c3f66
Fix compiler warnings in contracts and mocks
izqui 1a5d332
Update solidity-coverage settings
izqui 5153348
Fix coverage for app_base_lifecycle.js
izqui 3c1d91a
Mocks: fix paths to be relative to contracts/
sohkai 4b0d6aa
Remove unnecessary migration
sohkai 083e038
Merge branch 'dev' into solc-0.4.24
sohkai f3a07ec
Make ACL oracle check a staticcall
izqui 2e67157
Mocks: fix compile warnings
sohkai e480100
Pin truffle and solidity-coverage versions
izqui c59e01b
Merge branch 'dev' into solc-0.4.24
sohkai 95c6e21
Skip ACLSyntaxSugar from coverage
izqui d58d7e1
test: wrap solidity tests in JS runner
sohkai 277290e
test: remove unnecessay .call()s
sohkai 430358b
test: stop emitting events from APMNamehash mock
sohkai 78d5ce4
Manually link library in runSolidityTest removing the migration
izqui f3db3ca
Linter ignore test dir
izqui ccacd79
Manually link library in runSolidityTest removing the migration (#396)
sohkai 6b94631
test: fix APMNamehashWrapper
sohkai cba432e
test: fix compile warnings
sohkai bb32ba1
Make interface functions external
sohkai 291c1a6
Merge pull request #395 from aragon/wrap-solidity-tests
sohkai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
contracts/test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,8 @@ | ||
// NOTE: Upgrading to solidity-coverage 0.4.x breaks our tests | ||
|
||
const libFiles = require('glob').sync('contracts/lib/**/*.sol').map(n => n.replace('contracts/', '')) | ||
const interfaces = [ | ||
'acl/IACL.sol', | ||
'acl/IACLOracle.sol', | ||
'acl/ACLSyntaxSugar.sol', | ||
'common/IForwarder.sol', | ||
'common/IVaultRecoverable.sol', | ||
'evmscript/IEVMScriptExecutor.sol', | ||
'kernel/IKernel.sol', | ||
] | ||
const skipFiles = ['lib', 'test', 'acl/ACLSyntaxSugar.sol'] | ||
|
||
module.exports = { | ||
norpc: true, | ||
compileCommand: '../node_modules/.bin/truffle compile', | ||
testCommand: 'node --max-old-space-size=4096 ../node_modules/.bin/truffle test --network coverage', | ||
skipFiles: interfaces.concat(libFiles), | ||
copyNodeModules: true, | ||
skipFiles, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
node_modules | ||
contracts/lib | ||
contracts/test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh this is much needed; they can detect interfaces now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it! Was testing to see the cause of requirement for
.call()
was the fact that interfaces weren't being instrumented, which was not the case, but it was a nice surprise.