Add Linter (Solium)

[Quazia]

WIP merge, this PR when finished will address issue #53. For more information on the progress see the issue. So far only non-breaking fixes have been applied but not all warnings/errors have been handled so far.

[izqui]

Thanks for taking the time, great work! :)

My brain hurts with the doubled indentation. How does everyone feel about it?

[readevalprint]

@izqui I prefer the 4 spaces personally

[Quazia]

I can switch it back to 2 spaces and change the Solium settings if that's the preference. I just went with defaults. Personally I think 4 spaces is easier to read but I'm an outsider.

[izqui]

Let's do 4 :)

…

I can switch it back to 2 spaces and change the Solium settings if that's the preference. I just went with defaults. Personally I think 4 spaces is easier to read but I'm an outsider. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#59 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAbTYEii5ZDMkMf7Lnv6kiVAgw6psygAks5sPHUugaJpZM4OafvP> .

[readevalprint]

@Quazia sorry, some major refactoring has been going on so there are a few conflicts

[Quazia]

No problem. The non-trivial errors/warnings are still present as well as the parser error related to the solidity-parser repo. If you want to merge in in spite of this I can clean up the conflicts?

[readevalprint]

Yeah we'd definitely appreciate it, we can try to fix the bigger issues in a different PR. I'd rather get this in before any other conflicts.

[Quazia]

Alright, conflicts should be handled now. Should I add issues for the non-trivial errors and warnings?

[izqui]

I think last merge created some more conflicts

[Quazia]

Alright I'll handle them first thing this morning, hopefully I'll be able to get ahead of it this time!

[Quazia]

Alright, I believe everything should be sorted out now. The only rule I disabled was mixed_case as I assume since most instances are functions this would be a breaking error. The only other warning still present is:

In /home/quazia/Sites/quazia/aragon-core/contracts/kernel/organs/IOrgan.sol, line 6:
contract IOrgan is DAOStorage {
                              ^-- WARNING: Use of empty block statement {}

There's also still 2 instances of the parser error triggered by solidity-parser:

An error occurred while running the linter on /home/quazia/Sites/quazia/aragon-core/contracts/kernel/Kernel.sol:
Error: An error occured while parsing the source code:
SyntaxError: Expected "=:", "hex", "let", "{", "}", comment, end of line, number, string, or whitespace but "r" found. Line: 108, Column: 17

Hopefully this issue with the parser will be resolved.

In one place the statement id = id is used to circumvent an unused variable warning. This is sloppy but I didn't see any other way to avoid the warning and I believe leaving this warning on is useful.