Identifying signature requests initiated from profile app

[Schwartz10]

When the signer panel opens with a signature request from the profile app, the AppInstanceLabel component displays “unknown” because the profile application is not tied to a smart contract.

I wanted to check and see if we have a specific design request to handle this situation, and/or if there are any specific implementation suggestions. I think (for now) it makes sense to create a custom AppInstanceLabel component for Aragon apps without smart contracts (what should we call that?), and conditionally render the InstanceLabel from the SignerPanel depending on the type of app that requested the signature.

Do people have thoughts on this? If this seems like low priority, I’m happy to adjust the current AppInstanceLabel component to handle smart contract-less apps as well.

[luisivan]

I’m happy to adjust the current AppInstanceLabel component to handle smart contract-less apps as well.

Yeah I think this would make more sense than having a different component. Thoughts @bpierre @sohkai?

[bpierre]

Yes I agree, the profile app is the only internal app to use the signer panel for now, so it makes sense to just adjust the AppInstanceLabel for it.

[sohkai]

cc @dizzypaty This is the "Unknown" label (because Profiles is not attached to a contract):

[luisivan]

Great, then @Schwartz10 feel free to open a PR and @bpierre will review it!

[sohkai]

Closing for now; the Profiles app is not on a timeline to be included in the client.