Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API refactor: App connectors transaction requirements #221

Open
0xGabi opened this issue Aug 20, 2020 · 0 comments
Open

API refactor: App connectors transaction requirements #221

0xGabi opened this issue Aug 20, 2020 · 0 comments
Assignees

Comments

@0xGabi
Copy link
Contributor

0xGabi commented Aug 20, 2020

This issue is to discuss and outline the scope of changes we may need to do to allow the app connector to add more details when sending transactions.

  • E.g. Finance and Agreement need token pre-approvals, and it would be easier if those connectors held logic to calculate these

Brett's comment on the subject:

It's becoming clearer now, especially with Agreements and Disputable Voting, that app actions will have more context about the periphery transactions related to an action.

For example, in order to start a disputable vote (called directly or at the beginning of a transaction path), users will have to include one (or two) approval pre-transactions. And for the Agreement, a challenger could have up to four pre-transactions related to token approvals before they actually submit the transaction that starts the challenge.

Given this, I've started leaning more and more on allowing app connectors to include more logic on actions they expose, rather than directly mirroring organization#appIntent().

An alternative to this is providing a standard for app connectors to "hook" into an appIntent() call (e.g. "if I'm included in the forwarding chain, add a transaction"), but this would also force us to configure the app connectors in the main connect() export.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants