Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Disputable Forwarding Path #228

Open
1 task
0xGabi opened this issue Aug 21, 2020 · 0 comments
Open
1 task

Support Disputable Forwarding Path #228

0xGabi opened this issue Aug 21, 2020 · 0 comments

Comments

@0xGabi
Copy link
Contributor

0xGabi commented Aug 21, 2020

Description

Support transaction paths as mentioned in the Agreement spec.

On a conceptual level, the current transaction pathing algorithm should be able to find transaction paths with a disputable app at the beginning. This path should even be executable if the Agreement and Disputable have been configured to not require any collateral/fees.

Approach

We should use the latest deployed organization to try sending an app intent. Currently, the org's permissions allow for Finance and Agent transfers to happen via a disputable vote.

  • Decide if any API changes are required
    • Theoretically, a user can figure out that the path we gave them is disputable

The API currently do not work because the forward() API has changed.

DisputableVoting's forward now includes an extra parameter in its forward() function: https://github.com/aragon/aragon-apps/blob/disputable_voting_app/apps/voting-disputable/contracts/DisputableVoting.sol#L236

We can detect which forwarding version is implemented via forwarderType(): https://github.com/aragon/aragonOS/blob/next/contracts/forwarding/IAbstractForwarder.sol#L16-L20

Which should be checked after verifying isForwarder().

@0xGabi 0xGabi added this to the Forwarding Paths modes milestone Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant