Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectVoting() not exported correctly from module #304

Open
0x44616564616c7573 opened this issue Nov 29, 2020 · 3 comments
Open

connectVoting() not exported correctly from module #304

0x44616564616c7573 opened this issue Nov 29, 2020 · 3 comments

Comments

@0x44616564616c7573
Copy link

When testing the standard voting example from the user guide using both CommonJS and ES6 on NodeJS 14 LTS and 15, connectVoting() is not being correctly exported as a default or named function. This breaks the standard voting DAO app connector instructions from the project's quick start guide, and may be related to issue #232. I'm not sure if this affects other app connectors, but it may be the case that they also are broken. I have also had the issue confirmed by another person I'm working with on a project on a separate device, so it's not localized to me. I've been able to test this against v0.8.0-alpha, v0.7.3, and v0.7.0 from npm of @aragon/connect-voting, while using @aragon/connect v0.7.0.

@0x44616564616c7573
Copy link
Author

0x44616564616c7573 commented Nov 29, 2020

For clarity, the example I am referring to is this one:
import connect from '@aragon/connect'
import connectVoting from '@aragon/connect-voting'

const org = await connect('example.aragonid.eth', 'thegraph')

// Connect the Voting app using the corresponding connector:
const voting = connectVoting(org.app('voting')) // <--- Failure occurs here

// Fetch votes of the Voting app
const votes = await voting.votes()

@daviddavo
Copy link

I'm having the same problem with @aragon/connect-finance and connectFinance. Searching on the GitHub code, these functions don't exist any more. Is this a docs problem?

@Barukimang
Copy link

@daviddavo for me to better understand, which Doc within the Connect Docs exactly are you using? https://hack.aragon.org/developers/tools/aragon-connect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants