Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slippage tolerance setting #43

Open
john-light opened this issue Aug 13, 2020 · 1 comment
Open

Add slippage tolerance setting #43

john-light opened this issue Aug 13, 2020 · 1 comment

Comments

@john-light
Copy link

Uniswap has a slippage tolerance setting that will cause a swap to fail if the trade results in slippage greater than x% of the price quoted to the user at the time they sign and broadcast the trade transaction. The user will lose the gas from their transaction but they at least won't end up overpaying by an unexpected amount.

Screenshot_2020-08-13 Uniswap Interface

Could convert.aragon.org implement something similar to prevent issues such as #41?

@sohkai
Copy link
Contributor

sohkai commented Aug 14, 2020

Unfortunately not, to my knowledge. The bonding curve mechanism does not currently contain a slippage protection mechanism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants