ERC3k: hash missing payload fields #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izqui
added
P0 🚒
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
=======================================
Coverage 22.78% 22.78%
=======================================
Files 9 9
Lines 158 158
Branches 17 17
=======================================
Hits 36 36
Misses 122 122
Continue to review full report at Codecov.
|
Evalir
added a commit
that referenced
this pull request
Oct 28, 2020
* Core, utils: Implement adaptative ERC165 (#87) * Core, utils: Implement adaptitive ERC165 * Expose function * Consistency * Apply suggestions from code review Co-authored-by: Enrique Ortiz <enrique@aragon.one> * Apply suggestions from code review Co-authored-by: Enrique Ortiz <enrique@aragon.one> * ERC3k: hash missing payload fields (#89) * Cleanup: core & create packages (#90) * Cleanup: core & create repos * Fix import * Core, create, utils: Proxies in Factory (#88) * Utils: Implement ERC1167ProxyFactory * Core, utils: Implement Initializable * Core, create, utils: use proxies in factory * Fix CI, CD * Fix test * pump gas Co-authored-by: Enrique Ortiz <hi@enriqueortiz.dev> * chore: update main npm package readme * Server: add pending review changes (#71) * Core, erc3k: Remove veto collateral * Make tests pass * Fix subgraph * Update to new registry * Fix subgraphs from conflicts Co-authored-by: Enrique Ortiz <enrique@aragon.one> Co-authored-by: Enrique Ortiz <hi@enriqueortiz.dev> Co-authored-by: Gabriel Garcia <gabrielpk.18@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.