Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC3K: Reorder hashed payload struct for clarity #92

Closed
Evalir opened this issue Oct 27, 2020 · 1 comment
Closed

ERC3K: Reorder hashed payload struct for clarity #92

Evalir opened this issue Oct 27, 2020 · 1 comment
Assignees
@Evalir
Labels
P1 🔜 'We need to do this ASAP' issues S3: Maintenance 👨‍💼 Make it shine T0: Core 🌞 Core issues
Milestone
v1.0: Mainnet launch

Comments

@Evalir
Copy link
Contributor

Evalir commented Oct 27, 2020

As per this note, we should reorder the payload properties being hashed to match how they've been defined in ERC3000Data.sol, for the sake of consistency.
@Evalir Evalir added P2 👀 'Lets do!' issues S3: Maintenance 👨‍💼 Make it shine labels Oct 27, 2020
@Evalir Evalir added this to the v1.0: Mainnet launch milestone Oct 27, 2020
@Evalir Evalir added the T0: Core 🌞 Core issues label Oct 27, 2020
@Evalir Evalir mentioned this issue Oct 27, 2020
Closed
@Evalir Evalir self-assigned this Nov 2, 2020
@izqui izqui added P1 🔜 'We need to do this ASAP' issues and removed P2 👀 'Lets do!' issues labels Nov 2, 2020
@Evalir Evalir removed their assignment Nov 11, 2020
@Evalir Evalir self-assigned this Dec 7, 2020
@Evalir
Copy link
Contributor Author

Evalir commented Dec 8, 2020

This ended up being fixed on #89

@Evalir Evalir closed this as completed Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Evalir Evalir

Labels
P1 🔜 'We need to do this ASAP' issues S3: Maintenance 👨‍💼 Make it shine T0: Core 🌞 Core issues
Projects
None yet
Milestone
v1.0: Mainnet launch
Development

No branches or pull requests
2 participants
@izqui @Evalir