Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename icons #32

Closed
bpierre opened this issue Dec 1, 2017 · 4 comments
Closed

Rename icons #32

bpierre opened this issue Dec 1, 2017 · 4 comments

Comments

@bpierre
Copy link
Contributor

bpierre commented Dec 1, 2017

Opening an issue after having discussed this with @izqui.

Our icon set is composed of actions (notifications, wallet, …) and app icons (tokens, fundraising, …). Some icons used for apps are also used to represent actions. At the moment, their name is describing the app they represent.

This is the Identity app icon, which is named IconIdentity:

You can see it being used in the Aragon menu:

image

And this same icon is also used as a “Transfer token” action in the Tokens app:

image

  • Icons names should describe what they represent in the most generic way, rather than the app they happen to represent (in the example above, it could be “user-add”).
  • If an app is using an icon from the Aragon UI icon set, this app is free to duplicate it.
@izqui
Copy link
Contributor

izqui commented Dec 1, 2017

👍

Regarding app icons, for all aragon-apps we are probably fine having the icons in aragon-ui, but ideally apps would define their icon filename in the manifest.json and then we would load it.

@sohkai
Copy link
Contributor

sohkai commented Dec 2, 2017

We'll be able to provide an icon path for aragon-apps' manifest.json since we need to copy over the assets from aragon-ui anyway. Better to dogfood.

@stale
Copy link

stale bot commented Jun 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for contributing to Aragon! 🦅

@stale stale bot added the abandoned label Jun 9, 2019
@bpierre
Copy link
Contributor Author

bpierre commented Jun 10, 2019

Closing as icon names are now coming from the design system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants