Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

建议把mask模块从overlay里分离出来 #11

Open
lianqin7 opened this issue Jun 13, 2013 · 4 comments
Open

建议把mask模块从overlay里分离出来 #11

lianqin7 opened this issue Jun 13, 2013 · 4 comments

Comments

@lianqin7
Copy link
Member

RT,就像 templatable 与 widget 的关系,mask 和 overlay 没有非常紧密的联系,个人觉得2者放在一个模块组里感觉不是很合适。分开独立发展更适合。

@afc163 @popomore

@afc163
Copy link
Member

afc163 commented Jun 13, 2013

鉴于目前只有 arale/dialog 使用到了 mask,可以把 mask 模块去掉并合并到 dialog 的代码中去。

@lianqin7
Copy link
Member Author

@afc163

我们这边有过非 dialog 但是要 mask 的需求的(比如新用户引导:tips + mask)。个人觉得mask还是单独一个模块吧:)

@lizzie
Copy link
Member

lizzie commented Aug 1, 2013

单独用 mask 的话, 不就直接 require('arale/overlay/1.1.2/mask') 返回 mask实例对象了么... tips里直接用这个对象了啊..

@lianqin7
Copy link
Member Author

lianqin7 commented Aug 1, 2013

@lizzie

是单独一个模块组的意思,就像由 overlay/mask 变成 mask/mask

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants