-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Response.authorization field #7
Comments
Why not, don't hesitate to submit PRs 😄 |
Thanks! |
Do you prefer to preserve a copy of the fields in params, or just go ahead and move them? |
I'm not sure to perfectly understand what you want to do, but my answer may be enough anyway: preserve backward compatibility |
That works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A few of the
ActiveMerchant::Billing::Response
attributes are based on "magic" from the params and options hash.Moving
from params to options enable these fields to be accessible directly. Authorization field example
Options include moving the fields from params to options, or duplicating them for backwards support where people may already be accessing them via Response.params.
Happy to put up a pull request.
The text was updated successfully, but these errors were encountered: