Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge case with changed limit on second page #65

Closed
chdanielmueller opened this issue Mar 24, 2020 · 0 comments · Fixed by #66
Closed

Edge case with changed limit on second page #65

chdanielmueller opened this issue Mar 24, 2020 · 0 comments · Fixed by #66

Comments

@chdanielmueller
Copy link
Contributor

Hi there,

I hit an edge case where someone used a result limit of 5 items, navigated to page 2, changed the limit to 10 items and can not navigate backwards.

Current:
offset = 5, limit = 10
-> hasPrevPage = false, prevPage = null

Expected:
offset = 5, limit = 10
-> hasPrevPage = true, prevPage = 1

I have already written a test for this case and the solution.
PR follows shortly.

Cheers,
Daniel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Offset greater than 0 smaller than limit
1 participant
@chdanielmueller