Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Shorten Spaces" to "Source Code" -tkatemb #26

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

trevtemba
Copy link
Contributor

Fixes #

Proposed Changes

@guardrails
Copy link

guardrails bot commented Nov 20, 2021

⚠️ We detected 33 security issues in this pull request:

Insecure Use of Dangerous Function (32)
Docs Details
💡 Title: Potential OS command execution, Severity: High
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/OS/execlp.c#L43
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/pf and sf.c#L3
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Count of different characters in a String.c#L5
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Counting specific characters in a string.c#L7
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Employee salary (Structures).c#L16
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Palindrome without strrev.c#L6
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Palindrome without strrev.c#L10
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Pointer to a structure.c#L6
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Pointer to a structure.c#L7
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Search for char in string, find freq and pos.c#L5
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Shopping bill.c#L5
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/String formatting.c#L7
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/String to ASCII.c#L9
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Student structure.c#L12
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Count of different characters in a String.c#L8
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Counting specific characters in a string.c#L11
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Employee salary (Structures).c#L33
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Palindrome without strrev.c#L8
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Palindrome without strrev.c#L9
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Pointer to a structure.c#L16
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Pointer to a structure.c#L18
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Pointer to a structure.c#L20
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Search for char in string, find freq and pos.c#L8
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Shopping bill.c#L7
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Shopping bill.c#L9
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Shopping bill.c#L14
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/String formatting.c#L10
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/String to ASCII.c#L16
💡 Title: Buffer overflow, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Student structure.c#L27
💡 Title: Use of scanf, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/palindrome_pyramid_pattern.c#L10
💡 Title: Use of scanf, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/pascal triangle.c#L6
💡 Title: Use of scanf, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/Multiple_Files_Example/mainMFWC.c#L14

More info on how to fix Insecure Use of Dangerous Function in C/C++.


Insecure Processing of Data (1)
Docs Details
💡 Title: Insecure use of format strings, Severity: Critical
https://github.com/aravindvnair99/C/blob/c036685a878ac0c47f8a47db03ea755654918e2e/Source Codes/pf and sf.c#L2

More info on how to fix Insecure Processing of Data in C/C++.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

Copy link
Owner

@aravindvnair99 aravindvnair99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkatemb can you resolve the conflicts?

…-Shorten-Spaces-tkatemb

Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
aravindvnair99
aravindvnair99 previously approved these changes Nov 20, 2021
Copy link
Owner

@aravindvnair99 aravindvnair99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkatemb LGTM! I resolved the conflicts. Try not to mix changes when using branches to avoid conflicts.

Signed-off-by: Aravind Nair <22199259+aravindvnair99@users.noreply.github.com>
@trevtemba
Copy link
Contributor Author

@aravindvnair99 Thank you for resolving! I'm new to GitHub, so I'm still familiarizing myself with the open-source workflow. Apologies for the conflicts.

@aravindvnair99
Copy link
Owner

aravindvnair99 commented Nov 21, 2021

@aravindvnair99 Thank you for resolving! I'm new to GitHub, so I'm still familiarizing myself with the open-source workflow. Apologies for the conflicts.

@tkatemb No issues, here are a few resources you could use:

Copy link
Owner

@aravindvnair99 aravindvnair99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkatemb Can you take a look at the failing status check?

The Codacy one: https://github.com/aravindvnair99/C/pull/26/checks?check_run_id=4274860172

@trevtemba
Copy link
Contributor Author

Hello, I committed the changes, and am currently trying to push said changes, I am getting a rejection for the push request (as seen in the image below).
image

@trevtemba
Copy link
Contributor Author

Ok, everything should be fixed now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants