Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background color depending on Theme #3

Closed
adrianvintu opened this issue Feb 24, 2020 · 5 comments
Closed

Background color depending on Theme #3

adrianvintu opened this issue Feb 24, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@adrianvintu
Copy link

Can you please make the background of the dialog configurable, or something like that?

For now, it is not respecting custom dark theme, it shows the background as white, no matter what theme is set.

@Arbaz-Softagics
Copy link
Owner

Theme support is already in my pending list. You will get that soon.

@Arbaz-Softagics Arbaz-Softagics added the enhancement New feature or request label Feb 24, 2020
@adrianvintu
Copy link
Author

Thank you, keep up the great work!

@Arbaz-Softagics
Copy link
Owner

Commons 0.6.9 available for theme support. Hope it helps.

@adrianvintu
Copy link
Author

@Arbaz-Softagics thank you, here are some notes:
on BLACK theme

  1. OK button color is not accent color
  2. icon "i" has WHITE round skinny circle, instead of possibly TEXT color? or maybe it looks better in white?
  3. icon "i" has WHITE font, instead of possibly TEXT color? or maybe it looks better in white?

on WHITE theme:
looks as previous, i.e. good.

Tested with:

    dialog(
      context,
      //Theme.of(context).accentColor,
      widget.highlightBackgroundColor,
      "",
      text,
      true,
      true,
      neutralText: "Ok",
      neutralAction: () {},
      customIcon: Icon(
        Icons.info_outline,
        size: 64,
        color: Colors.white,
      ),
    );

@Arbaz-Softagics
Copy link
Owner

Commons v 0.7.0 is available with new changes
1 - Button colors changed to accent color
2, 3 - Icon color looks batter in white.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants