-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info on P account page #982
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloschert
requested review from
seppeljordan,
rhklee,
Amittai-Aviram and
petsch0
March 31, 2024 09:43
seppeljordan
requested changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change. I had some issues with the wording in the tests though.
In an effort to demystify the "balance" info on the company's p account page, two more pieces of information have been added: "sum of planned p" and "sum of consumed p". The "balance" is then apparently nothing else than the consumed hours subtracted from the planned hours. In the `ShowPAccountDetailsUseCase` there is now one database request less needed. If you find this change sensible I would apply this pattern also to the R, A and PRD accounts.
sloschert
force-pushed
the
sebas/add-info-to-p
branch
from
April 10, 2024 14:27
e6e0fec
to
efae6e4
Compare
seppeljordan
requested changes
Apr 10, 2024
seppeljordan
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. CRx3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to demystify the "balance" info on the company's p account page, two more pieces of information have been added: "sum of planned p" and "sum of consumed p". The "balance" is then apparently nothing else than the consumed hours subtracted from the planned hours.
In the
ShowPAccountDetailsUseCase
there is now one database request less needed.If you find this change sensible I would apply this pattern also to the R, A and PRD accounts.
Plan: b05bef9c-4dbf-4cd1-9e99-59219dfa9c4b (3x)