Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't seem to work on Windows, Has error indicating its processing a .cmd as javascript #8

Closed
keithn opened this issue Sep 10, 2015 · 6 comments
Assignees
Labels

Comments

@keithn
Copy link

keithn commented Sep 10, 2015

20150910-16:21:22.859(12)? (STDERR)
W20150910-16:21:22.860(12)? (STDERR) C:\Sandpit\leaderboard.electrify\node_modules.bin\electron.cmd:1
W20150910-16:21:22.860(12)? (STDERR) (function (exports, require, module, __filename, __dirname) { @if EXIST "%~dp0
W20150910-16:21:22.860(12)? (STDERR) ^
W20150910-16:21:22.864(12)? (STDERR) SyntaxError: Unexpected token ILLEGAL
W20150910-16:21:22.864(12)? (STDERR) at Module._compile (module.js:439:25)
W20150910-16:21:22.864(12)? (STDERR) at Object.Module._extensions..js (module.js:474:10)
W20150910-16:21:22.864(12)? (STDERR) at Module.load (module.js:356:32)
W20150910-16:21:22.864(12)? (STDERR) at Function.Module._load (module.js:312:12)
W20150910-16:21:22.864(12)? (STDERR) at Function.Module.runMain (module.js:497:10)
W20150910-16:21:22.864(12)? (STDERR) at startup (node.js:119:16)
W20150910-16:21:22.865(12)? (STDERR) at node.js:929:3

Also tried to bundle it as a app using the NPM tools, it says it completed ok, but no program is in the .dist folder.

@arboleya
Copy link
Owner

@keithn Which version of Windows?

@keithn
Copy link
Author

keithn commented Sep 10, 2015

on windows 10

@arboleya
Copy link
Owner

Oh fine, I've spoted the issue through the source. It's simple, I'm going to release a fix for it this weekend.

@arboleya arboleya self-assigned this Sep 11, 2015
@keithn
Copy link
Author

keithn commented Sep 11, 2015

awesome! :) this is gonna be so goooooood :)

@arboleya
Copy link
Owner

Fixed in 1.2.2, please update.

I couldn't test on a Windows 10, so pls let me know if it worked.

Tks for reporting.

@keithn
Copy link
Author

keithn commented Sep 14, 2015

Yes, now when I run meteor I get the app. Also if I run meteor shell and electrify the app, I get an app to run in the .dist
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants