LPS-100538 Execute searchEngine.initialize to force index creation in case it doesn't exist #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… case it doesn't exist
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
jorgediaz-lr
changed the title
|
ci:test:sf |
|
ci:test:relevant |
✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes 48 seconds 187 msClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-100538 1 Successful Jobs:For more details click here. |
liferay-continuous-integration
added
ci:test:sf - success
and removed
ci:test:sf - success
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes 52 seconds 776 msClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-100538 1 Successful Jobs:For more details click here. |
liferay-continuous-integration
added
ci:test:relevant - failure
and removed
ci:test:relevant - pending
labels
❌ ci:test:relevant - 22 out of 25 jobs passed in 1 hour 53 minutes 50 seconds 170 msClick here for more details.Base Branch:Branch Name: master Copied in Private Modules Branch:Branch Name: master-private 3 Failed Jobs:22 Successful Jobs:
For more details click here.Failures unique to this pull:
For upstream results, click here. |
|
Hi @arboliveira Do you have any update about this PR? Thank you |
|
ci:test:search |
liferay-continuous-integration
added
ci:test:search - pending
ci:test:search - failure
and removed
ci:test:search - pending
labels
❌ ci:test:search - 0 out of 1 jobs passed in 15 minutes 55 seconds 647 msClick here for more details.Base Branch:Branch Name: master Copied in Private Modules Branch:Branch Name: master-private 1 Failed Jobs:For more details click here.Failures unique to this pull:
For upstream results, click here. |
|
ci:test:search |
❌ ci:test:search - 19 out of 22 jobs passed in 1 hour 20 minutes 25 seconds 926 msClick here for more details.Base Branch:Branch Name: master Copied in Private Modules Branch:Branch Name: master-private 3 Failed Jobs:19 Successful Jobs:
For more details click here.This pull contains no unique failures.Failures in common with acceptance upstream results at f56de07:
|
|
Hi @arboliveira Do you have any update about this PR? Thank you /cc: @lipusz |
|
Hi Jorge,
This might take some time to review: currently the SP1 features take the
priority and since there is no actual customer waiting for this fix I think
it's okay to return to this later.
Regards,
Tibor
…On Tue, Sep 10, 2019 at 12:09 PM Jorge Díaz ***@***.***> wrote:
Hi @arboliveira <https://github.com/arboliveira>
Do you have any update about this PR?
Thank you
/cc: @lipusz <https://github.com/lipusz>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#766?email_source=notifications&email_token=AAL4BYVLB5JYTED7AXR6FIDQI5W4ZA5CNFSM4IRC22NKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6KSKNA#issuecomment-529868084>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAL4BYTGV4DXFHV2QZ3LIGTQI5W4ZANCNFSM4IRC22NA>
.
--
*Tibor Lipusz*
*Project Manager, Search & Security SME @ Product Care*
*Liferay Hungary Kft.* | H-1138 Budapest, Madarász Viktor u. 47. a-b.,
Hungary
* <http://twitter.com/liferay>*
<http://www.liferay.com>
Enterprise. Open Source. For Life
*Visit Us: **www.liferay.com <http://www.liferay.com/>** | Like Us:
**facebook.com/liferay
<http://facebook.com/liferay>** | Follow Us: twitter.com/liferay
<http://twitter.com/liferay>*
<http://twitter.com/liferay>
Confidentiality Notice: This e-mail message, including any attachments, is
for the sole use of the intended recipient(s) and may contain confidential
and privileged information. Any unauthorized review, use, copying,
disclosure or distribution is prohibited. If you are not the intended
recipient, please contact the sender by reply e-mail and destroy all copies
of the original message.
|
|
Thank you for the info, @lipusz |
|
Do you have any update about this PR? Thank you |
|
Hi Jorge, As it's not related to any current customer issues, probably it will be picked after the ongoing LES development is done (end of Oct/early Nov). @arboliveira Correct me if I'm wrong. @jorgediaz-lr Can you please remove the [Technical Support] designation from the subject in the meantime? Sorry about the delay and thank you for your understanding. Regards, |
|
Hi @lipusz One month ago, you said:
Now you are saying:
In my opinion, product team will always have anything to do that is top priority due some deadline. (e.g.: after LES development: 7.3 release) If you think this won't be reviewed soon and it isn't an important issue, to avoid having this PR as a pending task in my PR list, I prefer simply closing it and leave the LPS unassigned. Thank you /cc: @arboliveira |
That's true, in general. Though currently we have a much tighter deadline than we have normally and that's causing to postpone anything else that is not urgent. We expect to have more time to follow-up on pending tasks after these developments are done. Your PR won't be forgotten I promise. Cheers, |
|
Do you have any update about this PR review? It is pending since October 2019. Regards, |
jorgediaz-lr
changed the title
|
Hi @arboliveira Did you read my last message? Thank you |
|
Hi @arboliveira @lipusz @BryanEngler, Do you have any update about this PR? Thank you |
|
@jorgediaz-lr we just started a new sprint today, this pr should be picked up by one of the search engineers during the sprint |
|
Hi @BryanEngler Thank you for the information. I will wait until new sprint is finished |
brandizzi
reviewed
Mar 9, 2020
| for (long companyId : companyIds) { | ||
| ReindexStatusMessageSenderUtil.sendStatusMessage( | ||
| ReindexBackgroundTaskConstants.SINGLE_START, companyId, | ||
| companyIds); | ||
|
|
||
| try { | ||
| for (SearchEngine searchEngine : searchEngines) { |
There was a problem hiding this comment.
Hello @jorgediaz-lr!
I'm taking care of this pull request. I wonder, is there some reason to get all search engines and initialize all of them? I mean, couldn't we just get the current search engine (with SearchEngineHelpverUtil.getSearchEngine(indexer.getSearchEngineId())) and initialize it?
Thanks!
There was a problem hiding this comment.
Hi @brandizzi,
I just copied the initialization code that is executed when you do a full reindex, to the partial reindex code.
During a full reindex, following code is executed:
- ReindexPortalBackgroundTaskExecutor.reindex(String className, long[] companyIds)
- SearchEngineInitializer.reindex()
- SearchEngineInitializer.reindex(int delay)
- SearchEngineInitializer.doReIndex(int delay)
- SearchEngineHelperImpl.initialize(long companyId)
In that code SearchEngineHelperImpl.initialize(long companyId) all search engines are initialized:
public synchronized void initialize(long companyId) {
if (_companyIds.containsKey(companyId)) {
return;
}
_companyIds.put(companyId, companyId);
for (SearchEngine searchEngine : _searchEngines.values()) {
searchEngine.initialize(companyId);
}
}
Am I missing something?
|
Merged here: brianchandotcom#86615 Thank you, @brandizzi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.