Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add introspection for global properties. #1890

Merged
merged 1 commit into from
May 18, 2022
Merged

Add introspection for global properties. #1890

merged 1 commit into from
May 18, 2022

Conversation

thorstenhater
Copy link
Contributor

Add accessors for the following items in global_properties

  • ion_species (name -> valence) RO
  • ion_data (name -> initial values) RO
  • ion_rev_pot (name -> rev pot mech) RO
  • Vm, rL, TK, Cm: RW

Fixes: #1802

@thorstenhater thorstenhater requested review from bcumming, akuesters, boeschf and AdhocMan and removed request for bcumming May 5, 2022 18:59
boeschf
boeschf approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@boeschf boeschf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me from an implementation standpoint. I am not quite sure what potential side effects would be, if any. Since this is a useful feature I approve.

@brenthuisman brenthuisman merged commit a408c1e into arbor-sim:master May 18, 2022
@thorstenhater thorstenhater deleted the py/grop-read-access branch August 1, 2022 07:39
@thorstenhater thorstenhater restored the py/grop-read-access branch August 1, 2022 07:39
@thorstenhater thorstenhater deleted the py/grop-read-access branch August 1, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boeschf boeschf boeschf approved these changes

@akuesters akuesters Awaiting requested review from akuesters

@AdhocMan AdhocMan Awaiting requested review from AdhocMan

Assignees

@boeschf boeschf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make cable_global_properties readable
3 participants
@thorstenhater @boeschf @brenthuisman