Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly fix CmdLineArgs memory leak #65

Closed
aprokop opened this issue May 17, 2019 · 0 comments · Fixed by #66
Closed

Properly fix CmdLineArgs memory leak #65

aprokop opened this issue May 17, 2019 · 0 comments · Fixed by #66
Labels
bug Something isn't working

Comments

@aprokop
Copy link
Contributor

aprokop commented May 17, 2019 •
edited
Loading

#63 was incomplete. It fixed the double memory release, but not the leak.

The argv() call should return a copy of the array, so that benchmark may modify as it wants to.
@aprokop aprokop changed the title Properly fix CmdLineArgs Properly fix CmdLineArgs memory leak May 17, 2019
@aprokop aprokop added the bug Something isn't working label May 17, 2019
@masterleinad masterleinad mentioned this issue May 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix memory management in CmdLineArgs masterleinad/ArborX
1 participant
@aprokop