Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neodigm Utils Shake | Accept an Element ref or a query string #88

Closed
neodigm opened this issue Sep 17, 2023 · 4 comments
Closed

Neodigm Utils Shake | Accept an Element ref or a query string #88

neodigm opened this issue Sep 17, 2023 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@neodigm
Copy link
Collaborator

neodigm commented Sep 17, 2023

It makes sense to clearly define the contract signature before beginning work on TypeOn.

If possible make backward compatible.

Consider this use case wherein the query results in more than one element (loop).

@neodigm neodigm added enhancement New feature or request good first issue Good for newcomers labels Sep 17, 2023
@neodigm
Copy link
Collaborator Author

neodigm commented Sep 17, 2023

FYI - This is an easy task.

@neodigm
Copy link
Collaborator Author

neodigm commented Sep 18, 2023

I wonder if Shake and TypeOn should return an instance of neodigmUtils or a collection of effected elements?

Not sure that I agree with the premiss that we should pass in an element reference. It seems like its breaking established norms.

@neodigm
Copy link
Collaborator Author

neodigm commented Sep 19, 2023

Decided not to make this backward compatible, I don't think that it should except an element. Its too much trouble for the implementation coder (DX).

The chaining works like this:

neodigmUtils.shake( "#js-hearts" ).shake( "#js-clubs" ).shake()

I am going to close this shortly, but based on the description of the task, I may mark it "not fixing", or whatever.

@neodigm
Copy link
Collaborator Author

neodigm commented Sep 19, 2023

This issue is resolved in v3.1. No doc changes needed.

@neodigm neodigm closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant