Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no_std support? #9

Closed
WaffleLapkin opened this issue Oct 9, 2020 · 3 comments · Fixed by #12
Closed

no_std support? #9

WaffleLapkin opened this issue Oct 9, 2020 · 3 comments · Fixed by #12

Comments

@WaffleLapkin
Copy link
Contributor

It seems like xvii can work in no_std context too - the only methods that require std are to_{uppercase,lowercase} (and there can be replacement that uses fmt::Display instead of converting to string)

@archer884
Copy link
Owner

Ok, I looked into doing this, but it definitely seems like a bigger job than just removing those methods. I'd be fine with offering a no_std feature or something, but I'm not clear on how. If you're interested, take a shot at implementing it and send me a PR.

@WaffleLapkin
Copy link
Contributor Author

I'll make a PR (probably after you'll merge the existing ORs, so there will be fewer conflicts), but until then, can you reopen the issue?

@archer884
Copy link
Owner

As a matter of principle, I don't consider this to be an issue with the library, and it's not something I have the time to fix, so I kind of did a "closed - won't fix" thing, you know? I'll reopen it for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants