Increase add mining context timeout to max_timeout (#1108)

archethic-foundation · Jun 19, 2023 · f11e049 · f11e049
1 parent 721f3b1
commit f11e049
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 11 deletions.
diff --git a/lib/archethic/mining.ex b/lib/archethic/mining.ex
@@ -15,6 +15,7 @@ defmodule Archethic.Mining do
   alias __MODULE__.WorkflowRegistry
 
   alias Archethic.P2P
+  alias Archethic.P2P.Message
   alias Archethic.P2P.Message.ReplicationError
 
   alias Archethic.TransactionChain.Transaction
@@ -104,7 +105,7 @@ defmodule Archethic.Mining do
         io_storage_nodes_view
       ) do
     tx_address
-    |> get_mining_process!()
+    |> get_mining_process!(Message.get_max_timeout())
     |> DistributedWorkflow.add_mining_context(
       validation_node_public_key,
       P2P.get_nodes_info(previous_storage_nodes_keys),
@@ -199,7 +200,7 @@ defmodule Archethic.Mining do
   end
 
   defp get_mining_process!(tx_address, timeout \\ 3_000) do
-    retry_while with: exponential_backoff(100, 2) |> expiry(timeout) do
+    retry_while with: constant_backoff(100) |> expiry(timeout) do
       case Registry.lookup(WorkflowRegistry, tx_address) do
         [{pid, _}] ->
           {:halt, pid}

diff --git a/lib/archethic/p2p/message/add_mining_context.ex b/lib/archethic/p2p/message/add_mining_context.ex
@@ -22,7 +22,9 @@ defmodule Archethic.P2P.Message.AddMiningContext do
 
   alias Archethic.Crypto
   alias Archethic.Mining
+  alias Archethic.P2P.Message
   alias Archethic.P2P.Message.Ok
+  alias Archethic.TaskSupervisor
   alias Archethic.Utils
 
   @type t :: %__MODULE__{
@@ -46,15 +48,21 @@ defmodule Archethic.P2P.Message.AddMiningContext do
         },
         _
       ) do
-    :ok =
-      Mining.add_mining_context(
-        tx_address,
-        validation_node,
-        previous_storage_nodes_public_keys,
-        chain_storage_nodes_view,
-        beacon_storage_nodes_view,
-        io_storage_nodes_view
-      )
+    Task.Supervisor.async_nolink(
+      TaskSupervisor,
+      fn ->
+        Mining.add_mining_context(
+          tx_address,
+          validation_node,
+          previous_storage_nodes_public_keys,
+          chain_storage_nodes_view,
+          beacon_storage_nodes_view,
+          io_storage_nodes_view
+        )
+      end,
+      timeout: Message.get_max_timeout(),
+      shutdown: :brutal_kill
+    )
 
     %Ok{}
   end