Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase add mining context timeout to max_timeout #1108

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jun 19, 2023

Description

There is some possibility due to high network latency that a coordinator node receive a start mining message after the timeout of processing the context received from cross validation nodes.
In this case the coordinator wait for the context it'll never receive and the cross validation node wait for the validation stamp they'll never receive.
The coordinator fall in timeout due to no context received and notify the welcome node of transaction failure. While the cross validation nodes elect a new coordinator node and continue the validation.

This PR fixes it by increasing the add mining context processing to the maximum time before changing the coordinator node

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working mining Involve transaction validation and mining labels Jun 19, 2023
@Neylix Neylix added this to the 1.2.0 milestone Jun 19, 2023
@samuelmanzanera samuelmanzanera merged commit f11e049 into archethic-foundation:develop Jun 19, 2023
2 checks passed
@Neylix Neylix deleted the Increase-add-mining-context-timeout branch June 20, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mining Involve transaction validation and mining
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants