Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve dark mode in Echarts. #244

Closed
apoorv-2204 opened this issue Feb 25, 2022 · 7 comments
Closed

Resolve dark mode in Echarts. #244

apoorv-2204 opened this issue Feb 25, 2022 · 7 comments
Assignees
Labels
bug Something isn't working feature New feature request good first issue Good for newcomers UI Invole user interface

Comments

@apoorv-2204
Copy link
Contributor

apoorv-2204 commented Feb 25, 2022

Problem to solve

When forced dark mode , adjust colors accordingly
image

Solution

Before rendering the echarts call a function which returns a color js object based on time , either day or night,
Upon receiving the js object assign the static places with color_obj.line_color , ... etc

@apoorv-2204 apoorv-2204 added the feature New feature request label Feb 25, 2022
@apoorv-2204 apoorv-2204 self-assigned this Feb 25, 2022
@ghost ghost changed the title [enhancement]Add dark mode to Echarts. Add dark mode to Echarts. Feb 25, 2022
@ghost ghost added core team Assigned to the core team UI Invole user interface labels Feb 25, 2022
@internet-zero
Copy link
Member

Hey team! Please add your planning poker estimate with ZenHub @apoorv-2204 @imnik11 @nilesh-uniris @roychowdhuryrohit-dev @samuel-uniris

@ghost ghost mentioned this issue Apr 7, 2022
4 tasks
@ghost ghost added good first issue Good for newcomers and removed core team Assigned to the core team labels May 5, 2022
@ghost
Copy link

ghost commented May 9, 2022

@apoorv-2204 can you try to reproduce it by forcing the dark theme like: var chart = echarts.init(dom, 'dark');

@apoorv-2204
Copy link
Contributor Author

apoorv-2204 commented May 9, 2022

@apoorv-2204 can you try to reproduce it by forcing the dark theme like: var chart = echarts.init(dom, 'dark');

Hi @samuel-uniris
This image is var chart = echarts.init(dom, 'dark');
image


  • We can have argument "dark" for echarts, which gets dark color-scheme for graphs
    which apply specific color to each elements of graphs , we can get info regarding the theme
    from url dark or blue.
  • In dark Archethic and blue Uniris theme, It will be nice to have same color schemes
    as it has nice contrast with both the themes.

@apoorv-2204 apoorv-2204 self-assigned this May 10, 2022
@apoorv-2204 apoorv-2204 changed the title Add dark mode to Echarts. Resolve dark mode in Echarts. May 10, 2022
@apoorv-2204 apoorv-2204 added the bug Something isn't working label May 10, 2022
@apoorv-2204
Copy link
Contributor Author

Hello, @samuel-uniris and @Neylix and @internet-zero and @blackode
Hello Team,
Guys, What do you think about this dark theme?

image.png

@ghost
Copy link

ghost commented May 10, 2022

You only changed the website theme but no echarts right ?

@ghost
Copy link

ghost commented May 10, 2022

@apoorv-2204 can you try to reproduce it by forcing the dark theme like: var chart = echarts.init(dom, 'dark');

Hi @samuel-uniris
This image is var chart = echarts.init(dom, 'dark');
image


  • We can have argument "dark" for echarts, which gets dark color-scheme for graphs
    which apply specific color to each elements of graphs , we can get info regarding the theme
    from url dark or blue.
  • In dark Archethic and blue Uniris theme, It will be nice to have same color schemes
    as it has nice contrast with both the themes.

Can you force echarts to render in a single mode(i.e light) if we don't have a dark theme for the explorer ?

@apoorv-2204
Copy link
Contributor Author

apoorv-2204 commented May 10, 2022

You only changed the website theme but no echarts right ?

  • right

Hi,
from documentation :

  • echarts should automatically adjust to dark mode (w.r.t background), (But it didn't )
  • So I created method for dark and default view to return corresponding chart design.

ghost pushed a commit that referenced this issue May 12, 2022
Enforce light theme by default for echarts dashboard graphs, as we don't have yet a dark theme.
@ghost ghost closed this as completed May 12, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature New feature request good first issue Good for newcomers UI Invole user interface
Projects
None yet
Development

No branches or pull requests

2 participants