Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve dark mode in echarts #244 || add dark mode #310

Merged
5 commits merged into from
May 12, 2022
Merged

Resolve dark mode in echarts #244 || add dark mode #310

5 commits merged into from
May 12, 2022

Conversation

apoorv-2204
Copy link
Contributor

@apoorv-2204 apoorv-2204 commented May 10, 2022

Description

  • Add dark mode support

Fixes # (issue)

Type of change

#244
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@apoorv-2204 apoorv-2204 requested review from Neylix and a user May 10, 2022 11:37
@blackode blackode reopened this May 10, 2022
@apoorv-2204 apoorv-2204 marked this pull request as draft May 11, 2022 05:53
@apoorv-2204
Copy link
Contributor Author

Enforce white background in dark mode .

vmware_eppj712VNp

vmware_J2lwm0xWMS

@apoorv-2204 apoorv-2204 marked this pull request as ready for review May 11, 2022 07:26
assets/js/app.js Outdated Show resolved Hide resolved
@ghost ghost merged commit b16b6a6 into archethic-foundation:develop May 12, 2022
@apoorv-2204 apoorv-2204 deleted the Resolve_dark_mode_in_Echarts_#244 branch June 3, 2022 14:05
@ghost ghost added bug Something isn't working UI Invole user interface labels Jun 3, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI Invole user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants