Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Metric issues, : poller don't get metrics correctly #455

Closed
Tracked by #146
Neylix opened this issue Jul 17, 2022 · 5 comments
Closed
Tracked by #146

Resolve Metric issues, : poller don't get metrics correctly #455

Neylix opened this issue Jul 17, 2022 · 5 comments
Assignees
Labels
bug Something isn't working feature New feature request UI Invole user interface

Comments

@Neylix
Copy link
Member

Neylix commented Jul 17, 2022

Describe the problem you discovered

  • Metric should include all txns
  • when timeout, metric dashboard should have metrics have of node itself.
    image

Also on the dashboard it's seems that the datas are additionned instead of being averaged

Describe the solution you'd like

Metric poller should retrieve datas without error.
Dashboard view should have accurate values

@Neylix Neylix added bug Something isn't working UI Invole user interface labels Jul 17, 2022
@apoorv-2204
Copy link
Contributor

apoorv-2204 commented Jul 25, 2022

Any way to reproduce it ? @Neylix

@internet-zero
Copy link
Member

Hey team! Please add your planning poker estimate with ZenHub @apoorv-2204 @Neylix @prix-uniris

@ghost ghost mentioned this issue Aug 2, 2022
18 tasks
@apoorv-2204 apoorv-2204 changed the title Metric poller don't get metrics correctly Resolve Metric issues, : poller don't get metrics correctly Aug 3, 2022
@apoorv-2204 apoorv-2204 added the feature New feature request label Aug 5, 2022
@ghost
Copy link

ghost commented Aug 17, 2022

Also on the dashboard it's seems that the datas are additionned instead of being averaged

I think this is coming because the metrics exposed are not within the interval of 5s but global. The distribution/histogram metrics expose insights but without aggregate by scrape interval.
Instead it's the aggregating tool which should do it.
The problem is the _sum and _count metrics are increasing over time which is causing the increase line in the graph.
We should either:

For example something like: increase[5s] = count at 10s - count at 5s

@internet-zero
Copy link
Member

The issue estimate has been increased to 21, due to the increase in work

@samuelmanzanera
Copy link
Member

Closed by #590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature New feature request UI Invole user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants