Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework on the dashboard #590

Merged
merged 7 commits into from
Sep 29, 2022
Merged

Rework on the dashboard #590

merged 7 commits into from
Sep 29, 2022

Conversation

samuelmanzanera
Copy link
Member

Description

Fix the dashboard metrics aggregation and plotting.

Fixes #455

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

By running transactions the graphs should be updated with up/down lines.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

default_state()
|> Map.put(:interval, interval)
|> Map.put(:timer, timer)
state = %{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%{}
|>Map.put(..,..);
|>Map.put(...,...);

??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicitness is better in my opinion.
Map.put is nice when you want to update a map but to create it, this form seems better.

@apoorv-2204
Copy link
Contributor

Screenshot_20220927_144258
Wow!

@apoorv-2204
Copy link
Contributor

Can we have complete granfana telemetry ?

@samuelmanzanera
Copy link
Member Author

This should be managed separately.

@samuelmanzanera samuelmanzanera merged commit 80858a3 into develop Sep 29, 2022
@samuelmanzanera samuelmanzanera deleted the fix_dashboard2 branch September 29, 2022 16:39
@samuelmanzanera samuelmanzanera added the bug Something isn't working label Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants