Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dashboard #554

Closed
wants to merge 76 commits into from
Closed

Fix dashboard #554

wants to merge 76 commits into from

Conversation

samuelmanzanera
Copy link
Member

Description

Fix the dashboard metrics aggregation and plotting.

Fixes #455

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

By running transactions the graphs should be updated with up/down lines.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Samuel and others added 30 commits August 2, 2022 11:29
The fee burn have been removed from the transaction movements
and the burn is included as input.

This allows also the display of all the transactions targeting the
burning address.
* Added Register to Faucet After Transaction has been received in replication attestation and fetch the address for faucet as genesis address.
* Made fetch_genesis_address_remotely public func
Trigger repair on the right P2P network change
Fix also some test warnings
This will help to identify a transaction's token in a chain update (i.e NFT collection update) and to provide easier access to the token information
* Add GraphQL subscription  for error notification
* Added specific validation error msg
* Send validation error to the welcome node from the validation process
GenStage multi calls can be a bottleneck
This one is to try to leverage direct process spawning for each message
Renaming `from_map` to `cast` remove the confusion with the function
`to_map` which is used by the api while the `cast` is used by the db to
convert map to struct.
* Fix uco/nft ledger map in conditions

* Fix exit of standalone workflow

* Fix decoding DB recipient

Co-authored-by: neylix <julien.leclerc05@protonmail.com>
@samuelmanzanera samuelmanzanera changed the base branch from master to develop September 1, 2022 16:47
@samuelmanzanera samuelmanzanera self-assigned this Sep 1, 2022
@samuelmanzanera samuelmanzanera added bug Something isn't working UI Invole user interface labels Sep 1, 2022
@apoorv-2204
Copy link
Contributor

LGTM: Screenshot_20220905_113042

Copy link
Contributor

@apoorv-2204 apoorv-2204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice to me. 👍

assets/js/metric_config.js Show resolved Hide resolved
assets/js/metric_config.js Show resolved Hide resolved
lib/archethic/telemetry.ex Show resolved Hide resolved

return { "guage": guage, "max": 0 }
}

// for proper display of axis labels
function exponent_formatter(new_point) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can also be removed

@Neylix Neylix deleted the fix_dashboard branch October 30, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI Invole user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve Metric issues, : poller don't get metrics correctly
6 participants