Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC: Worker should not be executed while replicating a transaction from self repair #852

Closed
Tracked by #864
Neylix opened this issue Jan 19, 2023 · 0 comments
Closed
Tracked by #864
Assignees
Labels
bug Something isn't working self repair Involve SelfRepair mechanism smart contracts Involve smart contracts

Comments

@Neylix
Copy link
Member

Neylix commented Jan 19, 2023

Describe the problem you discovered

During the replication of a transaction, if the transaction has a recipient, the storage node triggers the execution of the corresponding smart contract.
This works as expected while replicating a new transaction, but the execution should not be triggered if the replication comes from the self repair as it is a past transaction and the execution has already been done by other nodes.

Describe the solution you'd like

In the Replication module, we should pass the parameter self_repair? to the Contracts.load_transaction and do not execute smart contract if it comes from self repair.

@Neylix Neylix added bug Something isn't working smart contracts Involve smart contracts self repair Involve SelfRepair mechanism labels Jan 19, 2023
@apoorv-2204 apoorv-2204 self-assigned this Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working self repair Involve SelfRepair mechanism smart contracts Involve smart contracts
Projects
None yet
Development

No branches or pull requests

2 participants