Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SC: Worker should not be executed while replicating a transaction from self repair#852 #864

Merged
merged 1 commit into from
Jan 30, 2023
Merged

SC: Worker should not be executed while replicating a transaction from self repair#852 #864

merged 1 commit into from
Jan 30, 2023

Conversation

apoorv-2204
Copy link
Contributor

@apoorv-2204 apoorv-2204 commented Jan 25, 2023 •
edited
Loading

Description

Fixes #

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@apoorv-2204 apoorv-2204 force-pushed the worker_should_not_be_executed_while_replicating_a_transaction_from_self_repair_#852 branch from ecbfebf to c453ae3 Compare January 25, 2023 16:00
@apoorv-2204 apoorv-2204 changed the title worker_should_not_be_executed_while_replicating_a_transaction_from_se… SC: Worker should not be executed while replicating a transaction from self repair#852 Jan 25, 2023
@apoorv-2204 apoorv-2204 self-assigned this Jan 25, 2023
@apoorv-2204 apoorv-2204 added bug Something isn't working smart contracts Involve smart contracts labels Jan 25, 2023
Neylix
Neylix requested changes Jan 26, 2023
View reviewed changes
lib/archethic/replication.ex Outdated Show resolved Hide resolved
lib/archethic/replication.ex Outdated Show resolved Hide resolved
@samuelmanzanera samuelmanzanera marked this pull request as ready for review January 26, 2023 18:56
@apoorv-2204 apoorv-2204 force-pushed the worker_should_not_be_executed_while_replicating_a_transaction_from_self_repair_#852 branch from 28fca10 to 3a673b0 Compare January 27, 2023 07:11
@Neylix Neylix merged commit 083d1a4 into archethic-foundation:develop Jan 30, 2023
@apoorv-2204 apoorv-2204 deleted the worker_should_not_be_executed_while_replicating_a_transaction_from_self_repair_#852 branch February 6, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelmanzanera samuelmanzanera samuelmanzanera approved these changes

@Neylix Neylix Neylix approved these changes

Assignees

@apoorv-2204 apoorv-2204

Labels
bug Something isn't working smart contracts Involve smart contracts
Projects
Dev Board
Status: Done 🍻
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apoorv-2204 @samuelmanzanera @Neylix