Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fetch summaries timeout #1084

Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jun 9, 2023

Description

in BeaconChain.fetch_and_aggregate_summaries there where 2 nested Task.async. This increase the risk of getting timeout.
To reduce this risk, the chunk by addresses is done before creating a task and there is only one task per {node, chunked addresses}

Fixes #1077

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit test still passes, running multiple node with benchmark

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Create 1 Task per chunk to avoid netsted Task
@Neylix Neylix added bug Something isn't working beacon chain Involve BeaconChain labels Jun 9, 2023
@Neylix Neylix added this to the 1.1.1 milestone Jun 9, 2023
Copy link
Member

@bchamagne bchamagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I only tested there are no regression:
I ran this on 3 nodes:

Archethic.BeaconChain.SummaryTimer.previous_summary(DateTime.utc_now()) |> Archethic.BeaconChain.fetch_and_aggregate_summaries(Archethic.P2P.authorized_and_available_nodes())

@Neylix Neylix merged commit 373db3e into archethic-foundation:1.1.1 Jun 9, 2023
@Neylix Neylix deleted the Improve-fet-summaries-timeout branch June 9, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beacon chain Involve BeaconChain bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants