Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix paging state #1357

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Fix paging state #1357

merged 1 commit into from
Dec 27, 2023

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Dec 27, 2023

Description

Fix an issue where the TransactionChain.fetch function could return an invalid result when data are fetched from DB and Remote

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added the bug Something isn't working label Dec 27, 2023
@bchamagne bchamagne added this to the 1.4.3 milestone Dec 27, 2023
@Neylix Neylix merged commit 9f95206 into archethic-foundation:develop Dec 27, 2023
2 checks passed
@Neylix Neylix deleted the Fix-paging-state branch December 30, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bchamagne bchamagne bchamagne approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Neylix @bchamagne