Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MUCO to UCO in transaction movements #1372

Merged
merged 4 commits into from
Jan 12, 2024

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jan 9, 2024

Description

This PR update the behavior of converting MUCO to UCO. The conversion is now done during the validation in the movements.
Updated the explorer view to display the conversion

Fixes #1368

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit tests
  • Update the reward address of a node (localhost:4000/settings)
    Using the chain of the new reward address, send the MUCO to another address, in the validation stamp the movement is UCO.
  • Also created a transfer of MUCO before applying this PR, then applied the PR with new explorer behavior, it works as it was previously (just display MUCO)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added mining Involve transaction validation and mining rewards enhancements labels Jan 9, 2024
@Neylix Neylix force-pushed the MUCO-UCO-stamp branch 3 times, most recently from 2c7c229 to ba43b9a Compare January 10, 2024 14:06
Copy link
Member

@bchamagne bchamagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like what you've done with ledgerOp & consume_input, looks cleaner.

Tested and numbers are good.

PREVIOUS INPUTS
Capture d’écran 2024-01-10 à 17 49 35

TX TRANSFER OF 0.01
Capture d’écran 2024-01-10 à 17 49 26

@samuelmanzanera samuelmanzanera merged commit bf4a48d into archethic-foundation:develop Jan 12, 2024
2 checks passed
@Neylix Neylix deleted the MUCO-UCO-stamp branch January 12, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements mining Involve transaction validation and mining rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MUCO to UCO transformation should be done during validation
3 participants