Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Genesis do not load spent utxo #1429

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Genesis do not load spent utxo #1429

merged 4 commits into from
Feb 15, 2024

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Feb 14, 2024

Description

This PR adds a new behavior for a genesis node of a chain.

  • Now a genesis node will store the transaction as a chain and not as IO transaction. This will help to ensure having consolidated utxo view.
  • When a genesis node adds an input for a chain, it will ensure this input has not been already consumed in a future transaction. This can happen during self repair or notifier.

How Has This Been Tested?

Unit test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix changed the base branch from develop to AEIP-21 February 14, 2024 10:20
@bchamagne bchamagne added this to the 1.4.8 milestone Feb 14, 2024
bchamagne
bchamagne approved these changes Feb 14, 2024
View reviewed changes
test/archethic/utxo_test.exs Outdated
],
unspent_outputs: [],
consumed_inputs: [
%UnspentOutput{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no consumed_inputs in protocol version 6.

bchamagne
bchamagne approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@bchamagne bchamagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samuelmanzanera
samuelmanzanera approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@samuelmanzanera samuelmanzanera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Neylix Neylix merged commit 7f0bb82 into archethic-foundation:AEIP-21 Feb 15, 2024
1 check passed
@Neylix Neylix deleted the Genesis-spent-utxo branch February 15, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelmanzanera samuelmanzanera samuelmanzanera approved these changes

@bchamagne bchamagne bchamagne approved these changes

Assignees
No one assigned
Labels
enhancements replication
Projects
None yet
Milestone
1.4.8
Development

Successfully merging this pull request may close these issues.
3 participants
@Neylix @samuelmanzanera @bchamagne