Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AEIP21-P2: UTXO synchronisation amongst validators #1435

Merged
merged 4 commits into from
Feb 26, 2024
Merged

AEIP21-P2: UTXO synchronisation amongst validators #1435

merged 4 commits into from
Feb 26, 2024

Conversation

bchamagne
Copy link
Member

Description

Share the utxo list amongst the validators and take the intersection.
This PR is based on #1434
Fixes #1407

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bchamagne bchamagne added mining Involve transaction validation and mining AEIP labels Feb 16, 2024
@bchamagne bchamagne added this to the AEIP-21: Phase2 milestone Feb 16, 2024
@bchamagne bchamagne linked an issue Feb 16, 2024 that may be closed by this pull request
AEIP-21: Use same unspent outputs across validators #1407
Closed
@Neylix Neylix deleted the branch archethic-foundation:AEIP-21-P2 February 21, 2024 14:20
@Neylix Neylix closed this Feb 21, 2024
@Neylix Neylix reopened this Feb 21, 2024
@Neylix Neylix changed the base branch from AEIP-21-phase2 to develop February 21, 2024 14:29
@Neylix Neylix changed the base branch from develop to AEIP-21-P2 February 22, 2024 14:13
@samuelmanzanera samuelmanzanera force-pushed the 1407-utxo-intersection branch 2 times, most recently from ef63bc6 to 7d16021 Compare February 23, 2024 08:39
@Neylix Neylix merged commit e06f714 into archethic-foundation:AEIP-21-P2 Feb 26, 2024
1 check passed
Neylix added a commit that referenced this pull request Mar 7, 2024
@bchamagne @samuelmanzanera @Neylix
AEIP21-P2: UTXO synchronisation amongst validators (#1435)
61c3ca6 
* Coordinator do the intersection of utxos coming from the crossvalidators

* Avoid reserialization to verify signature of P2P message

* Fix rebase

* Use VersionedUnspentOutput.hash over UspentOutput.hash

---------

Co-authored-by: Samuel Manzanera <samuelmanzanera@protonmail.com>
Co-authored-by: Neylix <julien.leclerc05@protonmail.com>
Neylix added a commit that referenced this pull request Mar 7, 2024
@bchamagne @samuelmanzanera @Neylix
AEIP21-P2: UTXO synchronisation amongst validators (#1435)
83e7d02 
* Coordinator do the intersection of utxos coming from the crossvalidators

* Avoid reserialization to verify signature of P2P message

* Fix rebase

* Use VersionedUnspentOutput.hash over UspentOutput.hash

---------

Co-authored-by: Samuel Manzanera <samuelmanzanera@protonmail.com>
Co-authored-by: Neylix <julien.leclerc05@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
AEIP mining Involve transaction validation and mining
Projects
None yet
Milestone
AEIP-21: Phase2
Development

Successfully merging this pull request may close these issues.

AEIP-21: Use same unspent outputs across validators
3 participants
@bchamagne @Neylix @samuelmanzanera