Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add control for mining process before starting mining #480

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Jul 28, 2022

Description

Add a control before starting mining a transaction, to check if the transaction is not already in mining process

Fixes #459

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Added latency in mining process, and tryed to send 2 times the same request. It blocked well the second transaction

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix merged commit 55bb170 into archethic-foundation:develop Jul 29, 2022
@Neylix Neylix deleted the Fix-Node-pool-selection branch July 29, 2022 09:19
@Neylix Neylix added the bug Something isn't working label Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node pool selected for sending network transaction should be the same as validation nodes pool
1 participant