Fix faucet limitation #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelmanzanera
force-pushed
the
fix_faucet_limitation
branch
from
849af39
to
4af84d0
Compare
apoorv-2204
reviewed
Sep 15, 2022
| @@ -9,6 +9,8 @@ defmodule ArchethicWeb.FaucetControllerTest do | |||
| PubSub | |||
| } | |||
|
|
|||
| alias Archethic.BeaconChain.ReplicationAttestation | |||
There was a problem hiding this comment.
alias Archethic.{
BeaconChain.ReplicationAttestation,??
Crypto,
P2P,
P2P.Node,
PubSub
}
apoorv-2204
reviewed
Sep 15, 2022
Comment on lines
15
to
16
| alias ArchethicWeb.TransactionSubscriber | ||
| alias ArchethicWeb.FaucetRateLimiter |
There was a problem hiding this comment.
alias ArchethicWeb.{TransactionSubscriber,FaucetRateLimiter}??
apoorv-2204
reviewed
Sep 15, 2022
| @@ -50,7 +53,12 @@ defmodule ArchethicWeb.FaucetControllerTest do | |||
|
|
|||
| describe "create_transfer/2" do | |||
| test "should show success flash with tx URL on valid transaction", %{conn: conn} do | |||
There was a problem hiding this comment.
MockCrypto.get_storage_nonce/0 ?? Maybe we can have this , for more deterministic test?
Call to TransactionSubscriber.get_max_confirmations requires storage nonce?I am not sure,
it may require more Mocks.
There was a problem hiding this comment.
This is the point to avoid blocking address , so if any address is not used it should not be blocked like the next test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the limitation of the faucet
Type of change
How Has This Been Tested?
Request funds more than 3 times on the same genesis address should be prevented
Checklist: