Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node settings UI #619

Merged
merged 8 commits into from
Oct 12, 2022
Merged

Node settings UI #619

merged 8 commits into from
Oct 12, 2022

Conversation

samuelmanzanera
Copy link
Member

@samuelmanzanera samuelmanzanera commented Oct 10, 2022

Description

This PR provides a web interface to customize node's reward address configuration.

Fixes #618

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Visit the page http://localhost:4000/settings
You should see the settings form.
Change the reward address.
A new transaction would have been submitted.
The new reward address is present in the node's details page.
Also, the previous received rewards would have been transferred to the new reward address (transformed as UCO).
The new reward address will receive the automatic rewards then.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera added UI Invole user interface system Involve system management API Involve API facing user labels Oct 10, 2022
@samuelmanzanera samuelmanzanera self-assigned this Oct 10, 2022
Copy link
Contributor

@apoorv-2204 apoorv-2204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might have a few visual clues. Otherwise great 👍

@samuelmanzanera
Copy link
Member Author

we might have a few visual clues. Otherwise great 👍

Ok I will try to make it more responsive

Copy link
Contributor

@apoorv-2204 apoorv-2204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@samuelmanzanera samuelmanzanera merged commit 9717765 into develop Oct 12, 2022
@samuelmanzanera samuelmanzanera deleted the node_settings_ui branch October 12, 2022 10:39
@samuelmanzanera samuelmanzanera added the feature New feature request label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Involve API facing user feature New feature request system Involve system management UI Invole user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants