Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate size fees based on transaction data instead of all transaction fields #648

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Calculate size fees based on transaction data instead of all transaction fields #648

merged 2 commits into from
Oct 21, 2022

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Oct 19, 2022

Description

Fixes #647

Type of change

  • Improvement

How Has This Been Tested?

Test files

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix force-pushed the Use-transaction-data-size-for-fee branch 2 times, most recently from 0adceb2 to 8501cd9 Compare October 20, 2022 13:23
@samuelmanzanera samuelmanzanera added bug Something isn't working Fee feature New feature request and removed bug Something isn't working labels Oct 21, 2022
@Neylix Neylix force-pushed the Use-transaction-data-size-for-fee branch from 8501cd9 to e4a3a8a Compare October 21, 2022 12:12
@samuelmanzanera samuelmanzanera merged commit 1e7d2f5 into archethic-foundation:develop Oct 21, 2022
@Neylix Neylix deleted the Use-transaction-data-size-for-fee branch October 25, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature New feature request Fee
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Neylix @samuelmanzanera