-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧩 566 & 645, Aggregate Fix & Fix self repair notifier #645 #671
Merged
samuelmanzanera
merged 20 commits into
archethic-foundation:develop
from
apoorv-2204:fix_self-repair_notifier_#645
Dec 2, 2022
Merged
🧩 566 & 645, Aggregate Fix & Fix self repair notifier #645 #671
samuelmanzanera
merged 20 commits into
archethic-foundation:develop
from
apoorv-2204:fix_self-repair_notifier_#645
Dec 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0f69d0
to
03f082d
Compare
17c6aa3
to
1046243
Compare
8df78dd
to
a0aca17
Compare
497d951
to
9f03fdd
Compare
12fc395
to
4e5ec54
Compare
This was
linked to
issues
Dec 2, 2022
This was referenced Dec 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
core team
Assigned to the core team
self repair
Involve SelfRepair mechanism
to-analyze
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Self-Repair:
-Determine which shards plummeted.
-Determine which transactions those shards were in charge of.
-Expand new shards for those transactions.
Proposed Solution :
%ShardRepair{}
message with two fields, thegenesis address
and thelast address
.fetch Transaction
andReplicate validate transaction chain
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Testing
To test in real condition we need to update some conditions to limit the number of nodes we need to run.
Here is the patch to apply which change
patch.txt
Then you can run 5 nodes
After the next self repair when they goes unavailable, the notifier of each node should be triggered. The last storage node of the transaction should send to 1 or 2 new node the ShardRepair message, and these nodes should replicate it.
Other node should also replicate a SummaryAggregate if the disconnected node was a storage node for it
Checklist: