Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notify last address #737

Merged

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Dec 2, 2022

Description

NotifyLastTransactionAddress message is not sending the notification for the genesis address of a chain. But in multiple case we want to get the last address of a chain from it's genesis address.

  • Added genesis address in the address list of the chain
  • Updated the default timestamp when requesting last_address from a chain without transaction

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working replication labels Dec 2, 2022
@samuelmanzanera samuelmanzanera merged commit 911bb4e into archethic-foundation:develop Dec 2, 2022
@Neylix Neylix deleted the Fix-Notify-last-address branch December 2, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working replication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants