-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transaction's content verification #736
Conversation
92f4670
to
2aa7a1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not work because it tries to validate the data transaction with the same schema.
AEWebCLI's data transaction format did not change and looks like this:
%{
"dir1" => %{
"file10.txt" => "H4sIAAAAAAAAA0vLzElVMDTgAgALt2T5CAAAAA",
"file11.txt" => "H4sIAAAAAAAAA0vLzElVMDTkAgBKhn_gCAAAAA"
},
"dir2" => %{
"hello.txt" => "H4sIAAAAAAAAA_NIzcnJ1yupKFHQyM_LqVRIy8xJVcjMU0jJLDLS5AIAt5R0vB4AAAA"
},
"dir3" => %{
"index.html" => "H4sIAAAAAAAAA7PJMLRz8QwyVsjMS0mt0Msoyc2x0QeKcQEAL-DoARkAAAA"
},
"file1.txt" => "H4sIAAAAAAAAA0vLzElVMFTgAgBapaazCAAAAA",
"file2.txt" => "H4sIAAAAAAAAA0vLzElVMOICAMGeIz8HAAAA",
"file3.txt" => "H4sIAAAAAAAAA0vLzElVMOYCAICvOCYHAAAA"
}
2022-12-06 14:07:05.340 [debug] Invalid AEWeb format [{"Required properties aewebVersion, metaData were not present.", "#"}]
@samuelmanzanera , I'll deal with this
we need to use branch on this pr and we need to use aeweb cli branch from this pr |
The issue was because the json schema was created for this data transaction format:
This format has been discussed but it is not implemented like this yet. Current format is:
Here's my suggestion to fix with current data transaction format: jsonschema.patch.tar.gz |
we will proceed with nested json only. |
archethic-foundation/aeweb-cli#87 |
2aa7a1b
to
1cdc2fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, I did the quick fix after the big merge of all AEWeb PRs.
This is ready to merge !
Tested with AEWEB CLI
Thanks 👍 |
Description
This PR improves data validation for transfer & hosting tx
For the hosting, this is based on the changes from archethic-foundation/aeweb-cli#87
Fixes #409
Type of change
Checklist: