Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aeweb] Incorporate new developments in ref txn #742

Closed

Conversation

apoorv-2204
Copy link
Contributor

@apoorv-2204 apoorv-2204 commented Dec 2, 2022

Description

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checklist:

  • My code dont follows the style guidelines of this project
  • I have not performed a self-review of my own code
  • I have not commented my code, particularly in hard-to-understand areas
  • I have not made corresponding changes to the documentation
  • My changes generate new warnings
  • I have added tests that prove my fix is effective or that my feature doesnt works
  • New and existing unit tests doesnt pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix
Copy link
Member

Neylix commented Dec 2, 2022

Hello,
there is already a graphql API to get the content of a transaction with the query

query {
  transaction(address: "xxx") {
    data {
      content
    }
  }
}

Why would you like to create a new API for this ?

@apoorv-2204
Copy link
Contributor Author

apoorv-2204 commented Dec 2, 2022

Hello, there is already a graphql API to get the content of a transaction with the query

query {
  transaction(address: "xxx") {
    data {
      content
    }
  }
}

Why would you like to create a new API for this ?

I was just checking whether you were online or not. 😆

@apoorv-2204 apoorv-2204 changed the title [Aeweb] Return content of reference Txn [Aeweb] Incorporate new developments in ref txn Dec 2, 2022
@apoorv-2204 apoorv-2204 self-assigned this Dec 2, 2022
Copy link
Member

@bchamagne bchamagne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we OK to not handle legacy websites?

@samuelmanzanera
Copy link
Member

samuelmanzanera commented Dec 6, 2022

Are we OK to not handle legacy websites?

If we do it before the mainnet reset it's ok otherwise we have to manage retro compatibility

@apoorv-2204
Copy link
Contributor Author

apoorv-2204 commented Dec 6, 2022

Are we OK to not handle legacy websites?

as we are resetting the protocol. and we need to merge this archethic-foundation/aeweb-cli#87.

@apoorv-2204
Copy link
Contributor Author

apoorv-2204 commented Dec 6, 2022

checks
@bchamagne

  • website hosting
  • directory listing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants