Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward the welcome node when forwarding tx#760 #783

Merged
merged 5 commits into from
Dec 21, 2022
Merged

Forward the welcome node when forwarding tx#760 #783

merged 5 commits into from
Dec 21, 2022

Conversation

apoorv-2204
Copy link
Contributor

@apoorv-2204 apoorv-2204 commented Dec 16, 2022

Description

Resolves the 760 by using sender public key, and with default params as Crypto.last_node_key , if not given,

 # Since welcome node is not anymore constant, as we want to unauthorised
  # nodes to do some labor. Following bootstrapping, the txn of a new node
  # is sent, with the welcome node being the same new node whose information
  # does not exist in the network. Thus solitary and distributed workflows
  # are more susceptible to failures.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • manual

    • Standalone workflow testing
    • distributed workflow testing
    • faucet testing on unauth nodes
    • aeweb cli on unauth nodes

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@apoorv-2204 apoorv-2204 self-assigned this Dec 16, 2022
@apoorv-2204 apoorv-2204 added bug Something isn't working core team Assigned to the core team labels Dec 16, 2022
@samuelmanzanera samuelmanzanera marked this pull request as ready for review December 16, 2022 15:10
Copy link
Member

@Neylix Neylix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appart the Logger level, it looks good to me.
I don't understand why you refactor the faucet controller as there is no link with the issue but anyway

lib/archethic/mining/standalone_workflow.ex Outdated Show resolved Hide resolved
@apoorv-2204
Copy link
Contributor Author

Appart the Logger level, it looks good to me. I don't understand why you refactor the faucet controller as there is no link with the issue but anyway

level, it looks good to me.

Reverted 👍

@samuelmanzanera samuelmanzanera linked an issue Dec 21, 2022 that may be closed by this pull request
@samuelmanzanera samuelmanzanera merged commit db0d9bb into archethic-foundation:develop Dec 21, 2022
@apoorv-2204 apoorv-2204 deleted the forward_the_welcome_node_when_forwarding_tx#760 branch December 22, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core team Assigned to the core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forward the welcome node when forwarding tx
4 participants