Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Adjustements #1000

Merged
merged 43 commits into from
Sep 11, 2024
Merged

UI Adjustements #1000

merged 43 commits into from
Sep 11, 2024

Conversation

redDwarf03
Copy link
Member

Description

Fixes #997

Type of change

  • UI/UX design
  • Refactorization

Material used:

Please delete options that are not relevant.

  • iOS (Mac)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Useful info for the reviewer:

@redDwarf03 redDwarf03 linked an issue Jun 16, 2024 that may be closed by this pull request
6 tasks
@redDwarf03 redDwarf03 marked this pull request as draft June 16, 2024 20:43
@redDwarf03 redDwarf03 force-pushed the 997-ui-adjustements branch 2 times, most recently from 870f756 to fb89ea6 Compare June 24, 2024 21:48
@redDwarf03 redDwarf03 force-pushed the 997-ui-adjustements branch 4 times, most recently from 94f6ee6 to e6d415b Compare July 23, 2024 15:47
@redDwarf03 redDwarf03 force-pushed the 997-ui-adjustements branch 2 times, most recently from 0875339 to 3b98971 Compare August 9, 2024 14:15
@redDwarf03 redDwarf03 force-pushed the 997-ui-adjustements branch 2 times, most recently from d9c856c to 97e913b Compare August 16, 2024 16:36
@IldySilva
Copy link

@redDwarf03 what do wee need more to merge this ?
it's a must.

@redDwarf03
Copy link
Member Author

redDwarf03 commented Sep 7, 2024

@redDwarf03 what do wee need more to merge this ? it's a must.

Bug fixing
The PR is a draft not ready to review

@IldySilva
Copy link

IldySilva commented Sep 7, 2024

@redDwarf03 what do wee need more to merge this ? it's a must.

Bug fixing The PR is a draft not ready to review
@redDwarf03
Can I offer any kind of support? I would like to work on Ui,Ux and Fix some bugs

@redDwarf03
Copy link
Member Author

redDwarf03 commented Sep 7, 2024

@redDwarf03 what do wee need more to merge this ? it's a must.

Bug fixing The PR is a draft not ready to review
@redDwarf03
Can I offer any kind of support? I would like to work on Ui,Ux and Fix some bugs

Thanks but this PR is managed internally by Archethic
You can help with other issues in backlog or ideally with wagmi new sdk in our repo

@redDwarf03
Copy link
Member Author

@IldySilva
I advice you to contribute here :

@redDwarf03 redDwarf03 marked this pull request as ready for review September 11, 2024 21:51
@redDwarf03
Copy link
Member Author

redDwarf03 commented Sep 11, 2024

I merge this too long PR to dev branch.
TODO after this in v3.0

  • Import not certified tokens
  • Disable fungibles tokens creation
  • Fix null exception in SignTransactionsConfirmationForm
  • Add DEX features
  • Fix issues with local node (processes too fast)

@redDwarf03 redDwarf03 merged commit 6aa0291 into dev Sep 11, 2024
3 checks passed
@redDwarf03 redDwarf03 deleted the 997-ui-adjustements branch September 11, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Adjustments
3 participants