Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension chrome - Block window widening #991

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Extension chrome - Block window widening #991

merged 1 commit into from
Jun 12, 2024

Conversation

Chralu
Copy link
Collaborator

@Chralu Chralu commented Jun 12, 2024

Fixes #974

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactorization

Material used:

Please delete options that are not relevant.

  • iOS (Smartphone/Tablet)
  • Android (Smartphone/Tablet)
  • Browser
  • Linux
  • Windows
  • iOS (Mac)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Patrol

Please list here the tests created in Patrol for this pull request.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Useful info for the reviewer:

@Chralu Chralu requested a review from redDwarf03 June 12, 2024 16:18
Copy link
Member

@redDwarf03 redDwarf03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iphone : ok
Web: ok
MacOs: ok
Ipad: ok but strange... (neither better nor worse than before)
Capture d’écran 2024-06-12 à 18 28 16

@Chralu Chralu merged commit ea29a30 into dev Jun 12, 2024
2 checks passed
@Chralu Chralu deleted the Chralu/issue974 branch June 12, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension chrome - Block window widening
2 participants