1777 optimize decentralized script for speed #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daren-thomas awesome!!, yes, the same for heating, please! |
|
@daren-thomas , the implementation works well! |
|
@daren-thomas could you please resolve the conflict? thanks |
|
@shanshanhsieh: no conflicts found :) let's merge already! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1777 but actually goes a bit farther. The calculation in
cea.technologies.chiller_absorption.calc_operating_conditionswas replaced - thesympy.linsolvemethod call is not needed if you already have a symbolic solution to the equation. See the docstring for that method on how this was done. The end product is a really long and hairy expression but so much faster.Execution speed went from:
I only worked on the cooling case. Do we need to do the same for heating?