Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2477 wrong column name in piping catalog #2478

Merged
merged 3 commits into from
Dec 3, 2019
Merged

2477 wrong column name in piping catalog #2478

merged 3 commits into from
Dec 3, 2019

Conversation

shanshanhsieh
Copy link
Contributor

this PR resolves #2477 the correct column name is updated

to test:

  1. run cea workflow for district-cooling-systems

@ShiZhongming
update column name in piping catalog
6fae506 
- `Description` to `Code`
@ShiZhongming
Update thermal_network.py
22eff46 
- the max_flow limit should be mdot_max_kgs
@shanshanhsieh shanshanhsieh requested review from gabriel-happle and removed request for jimenofonseca November 28, 2019 02:27
@shanshanhsieh shanshanhsieh mentioned this pull request Nov 28, 2019
Merged
@daren-thomas
Copy link
Member

@shanshanhsieh running the workflow as I type this. I'll get back to you with results and merge when done.

@gabriel-happle
Copy link
Contributor

after updating the mysterious function name the workflow runs through.
Thanks @reyery for the detective work.

@gabriel-happle
Copy link
Contributor

@shanshanhsieh workflow for heating is also running

@shanshanhsieh
Copy link
Contributor Author

@daren, both heating and cooling workflows ran through from my machine.
please merge this branch once the tests are passed from your side.

@daren-thomas
Copy link
Member

@shanshanhsieh I'm having a problem with the cooling workflow: It stops at the optimization step with AttributeError: 'module' object has no attribute 'uniform_reference_points'. I'm restarting it again just to make sure. Please don't merge yet.

@shanshanhsieh
Copy link
Contributor Author

@daren-thomas yes, we will only merge if that pass the test from your side
in both machine we tested, cea 2.26 is installed

@daren-thomas
Copy link
Member

@shanshanhsieh I'm having a problem with the cooling workflow: It stops at the optimization step with AttributeError: 'module' object has no attribute 'uniform_reference_points'. I'm restarting it again just to make sure. Please don't merge yet.

@daren-thomas
Copy link
Member

@shanshanhsieh confirmed: it doesn't work. blocks in the optimization step.

@shanshanhsieh
Copy link
Contributor Author

@daren-thomas please update your deap to v1.3.0 and try again

@daren-thomas
Copy link
Member

Updating deap did the trick! Thanks for the tip! merging :)

@daren-thomas daren-thomas merged commit bc80bac into master Dec 3, 2019
@daren-thomas daren-thomas mentioned this pull request Dec 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriel-happle gabriel-happle gabriel-happle approved these changes

@daren-thomas daren-thomas Awaiting requested review from daren-thomas

Assignees

@daren-thomas daren-thomas

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong column name in the piping catalog (cooling)
5 participants
@shanshanhsieh @daren-thomas @gabriel-happle @jimenofonseca @ShiZhongming