Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: PID Binding acceptance tests can fail when external service credentials no longer valid #154

Open
jrwdunham opened this issue Sep 10, 2018 · 1 comment
Labels
AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.

Comments

@jrwdunham
Copy link

jrwdunham commented Sep 10, 2018

Expected behaviour

The pid-binding.feature feature file of AMAUAT should pass against AM 1.7.x (and AM 1.8).

Current behaviour

This feature currently breaks when run on AM 1.7.2 because the private credentials that Archivematica uses to run the tests on a client's Handle server appear to no longer be valid. See #139 (comment).

Steps to reproduce

Run the AMAUAT acceptance test as described at #139 (comment).

Your environment (version of Archivematica, OS version, etc)

  • Archivematica a435c79 v1.7.2-rc.4
  • Storage Service f0cbc4d v0.12.0-rc.2
  • AMAUAT 12da463 master

For Artefactual use:
Please make sure these steps are taken before moving this issue from Review to Verified in Waffle:

  • All PRs related to this issue are properly linked 👍
  • All PRs related to this issue have been merged 👍
  • Test plan for this issue has been implemented and passed 👍
  • Release documentation (e.g. release notes, wiki documentation, etc) regarding this issue has been written 👍
@jrwdunham jrwdunham added the Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. label Sep 10, 2018
@jrwdunham
Copy link
Author

Possible Solutions

  1. Create a mock of the Handle service that returns fake responses so that the feature file can pass.
  2. Get new credentials for the client Handle service and continue to test with that. (Not a longterm solution.)

@ross-spencer ross-spencer changed the title Problem: PID Binding acceptance tests failing because external service credentials no longer valid Problem: PID Binding acceptance tests can fail when external service credentials no longer valid Nov 8, 2018
@ross-spencer ross-spencer added the AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests label Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AMAUAT Issues relating to the improvement of the AM Automated Acceptance tests Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Development

No branches or pull requests

2 participants